-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some improvements for packaged build [wip] #82
Conversation
Oh. Every time someone tries to do this, snap package breaks. So this would need extensive testing across all the building configuration. |
include(cmake/libusrsctp.cmake) | ||
include(cmake/libvpx.cmake) | ||
include(cmake/libyuv.cmake) | ||
if (NOT TG_OWT_PACKAGED_BUILD) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks the fallback logic when a library is not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that can't be right.
#85 should do the trick, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is wrong, as Ilya has already told me. 5986975 should fix that.
(However, there are linking problems with snap pack builds there; I haven't had a chance to reproduce it yet, but I'm still going to)
c5fc0b3
to
5986975
Compare
Integrated the Vitaly Lipatov's (lav@altlinux.ru) patch. It allows to build tg_owt with the system libyuv. If libyuv is not installed on the system, the build will be performed with libyuv from src/third_party/. Also fixed build in non-packaged mode.
c18ef25
to
ddcb55f
Compare
Is there still any work? Maybe close the PR and re-open when you would have time? |
reasonably |
I would like to share you my suggestions for improving TG_OWT_PACKAGED_BUILD.
Here they are:
The patch adds cmake rules for building tg_owt with libyuv from the system/packages.
Testing.
To test my changes I did the following:
To apply my changes, I replaced these lines in
centos_env/Dockerfile
fromto
and also edited .gitmodules:
The build was successful.
2) I did a packaged build under OpenBSD. Tested situations where libyuv is installed on the system and where it is not there, but everything you need is in
./src/third_party/libyuv
.In the first case, tg_owt was built with libyuv from the package, in the second, from
./src/third_party/libyuv
, i.e. everything is as expected.What do you think of my patches? If necessary, I am ready to improve them according to your wishes.
Perhaps I should test some other build variants?
Thanks anyway.